Formalize vaporview api in npm package#168
Open
AndrewNolte wants to merge 1 commit intoLramseyer:mainfrom
Open
Formalize vaporview api in npm package#168AndrewNolte wants to merge 1 commit intoLramseyer:mainfrom
AndrewNolte wants to merge 1 commit intoLramseyer:mainfrom
Conversation
AndrewNolte
force-pushed
the
AndrewNolte/stack/10
branch
from
876632e to
81eb639
Compare
This was referenced Mar 27, 2026
Closed
AndrewNolte
force-pushed
the
AndrewNolte/stack/10
branch
from
81eb639 to
83576cc
Compare
AndrewNolte
force-pushed
the
AndrewNolte/stack/10
branch
from
83576cc to
9f6265e
Compare
AndrewNolte
force-pushed
the
AndrewNolte/stack/10
branch
from
9f6265e to
5011e18
Compare
AndrewNolte
force-pushed
the
AndrewNolte/stack/10
branch
2 times, most recently
from
aa19ff5 to
4decf83
Compare
Lramseyer
reviewed
Mar 28, 2026
| return { | ||
| const api: VaporviewApi = { | ||
| // Events | ||
| onDidSetMarker: markerSetEvent, |
Owner
There was a problem hiding this comment.
Doesn't this type need to be changed to "MarkerSetEvent"?
Contributor
Author
There was a problem hiding this comment.
This is a function, not a type. It is quite confusing that they are almost the same name.
Lramseyer
reviewed
Mar 30, 2026
| export type SignalGroupContextMenuEvent = SignalGroupContext & DefaultWebviewContext; | ||
| export type NetlistVariableContextMenuEvent = NetlistVariableContext & DefaultWebviewContext; | ||
| export type CustomVariableContextMenuEvent = CustomVariableContext & DefaultWebviewContext; | ||
| export type RowItemContextMenuEvent = NetlistVariableContext | CustomVariableContext | SignalGroupContext | SignalSeparatorContext; No newline at end of file |
Owner
There was a problem hiding this comment.
RowItemContextMenuEvent was deleted
Contributor
Author
There was a problem hiding this comment.
Actually most of these are unused, including this one. I think they do have a place somewhere though.
Contributor
Author
There was a problem hiding this comment.
Like since these are used for users adding context buttons. I think they should be used internally too though
AndrewNolte
force-pushed
the
AndrewNolte/stack/10
branch
from
4decf83 to
7adead8
Compare
stack-info: PR: Lramseyer#168, branch: AndrewNolte/stack/10
AndrewNolte
force-pushed
the
AndrewNolte/stack/10
branch
from
7adead8 to
d23f997
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Stacked PRs:
View individual changes
Formalize vaporview api in npm package